chore: Update BenchmarkDotNet.Samples project #2898
Merged
+107
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI tests( |
timcassell
reviewed
Dec 5, 2025
Contributor
Author
|
I've modified code to use By default, Other changes
|
filzrev
force-pushed
the
chore-update-samples-project
branch
from
de0e036 to
623e247
Compare
timcassell
reviewed
Dec 16, 2025
filzrev
force-pushed
the
chore-update-samples-project
branch
from
8ab4a13 to
dfb94a1
Compare
Contributor
Author
|
I've fixed code that pointed by review comments. Additionally, I've added following changes.
|
timcassell
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following changes.
1. Add code to return exit code
Currently
void Mainis used, and it return ExitCode:0regardless validation/build/benchmark failure exists.This PR add code to return error code when failed. (Except for non-critical validation error)
2. Add
Properties/launchSettings.jsonAdd profiles to switch settings (VisualStudio or Use
--launch-profileargument).By default,
Defaultprofile is loaded. (It can be suppressed when pass--no-launch-profile)"workingDirectory": ".",setting is added to output logs based on current directory.(It'sproject directorywhen running on VS)Previous behavior output logs tobin/$(Configuration)/$(TargetFramework).3. Add code for debugging
Add dedicated config that is used when build with
Debugconfiguration.It's expected to be used for Debugging with "Run IntroBasic Benchmarks" profile.
Note:
When target benchmark define local config with
[Config(typeof(Config))].Job is merged with
ConfigUnionRule.Unionrule. And it's not works as expected.(Because both Job is executed that included GlobalConfig/LocalConfig)